Merge "Non-word characters don't terminate tag names."
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Tue, 6 Aug 2013 16:04:23 +0000 (16:04 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Tue, 6 Aug 2013 16:04:23 +0000 (16:04 +0000)
skins/CologneBlue.php
skins/Modern.php
skins/MonoBook.php
skins/Vector.php
tests/qunit/suites/resources/jquery/jquery.makeCollapsible.test.js

index 5ae8843..0370e05 100644 (file)
@@ -290,8 +290,8 @@ class CologneBlueTemplate extends BaseTemplate {
                <div id="siteNotice"><?php echo $this->getSkin()->getSiteNotice() ?></div>
                <?php } ?>
                <h1 id="firstHeading" lang="<?php
-                       $this->data['pageLanguage'] = $this->getSkin()->getTitle()->getPageViewLanguage()->getCode();
-                       $this->html( 'pageLanguage' );
+                       $this->data['pageLanguage'] = $this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode();
+                       $this->text( 'pageLanguage' );
                ?>"><span dir="auto"><?php echo $this->data['title'] ?></span></h1>
                <?php if ( $this->translator->translate( 'tagline' ) ) { ?>
                <p class="tagline"><?php echo htmlspecialchars( $this->translator->translate( 'tagline' ) ) ?></p>
index 56acd7e..8d778cf 100644 (file)
@@ -67,8 +67,8 @@ class ModernTemplate extends MonoBookTemplate {
 
        <!-- heading -->
        <div id="mw_header"><h1 id="firstHeading" lang="<?php
-               $this->data['pageLanguage'] = $this->getSkin()->getTitle()->getPageViewLanguage()->getCode();
-               $this->html( 'pageLanguage' );
+               $this->data['pageLanguage'] = $this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode();
+               $this->text( 'pageLanguage' );
        ?>"><span dir="auto"><?php $this->html( 'title' ) ?></span></h1></div>
 
        <div id="mw_main">
index c7a3ffc..f905587 100644 (file)
@@ -79,8 +79,8 @@ class MonoBookTemplate extends BaseTemplate {
        <?php if ( $this->data['sitenotice'] ) { ?><div id="siteNotice"><?php $this->html( 'sitenotice' ) ?></div><?php } ?>
 
        <h1 id="firstHeading" class="firstHeading" lang="<?php
-               $this->data['pageLanguage'] = $this->getSkin()->getTitle()->getPageViewLanguage()->getCode();
-               $this->html( 'pageLanguage' );
+               $this->data['pageLanguage'] = $this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode();
+               $this->text( 'pageLanguage' );
        ?>"><span dir="auto"><?php $this->html( 'title' ) ?></span></h1>
        <div id="bodyContent" class="mw-body">
                <div id="siteSub"><?php $this->msg( 'tagline' ) ?></div>
index 713ec8b..aba4791 100644 (file)
@@ -161,8 +161,8 @@ class VectorTemplate extends BaseTemplate {
                        <div id="siteNotice"><?php $this->html( 'sitenotice' ) ?></div>
                        <?php } ?>
                        <h1 id="firstHeading" class="firstHeading" lang="<?php
-                               $this->data['pageLanguage'] = $this->getSkin()->getTitle()->getPageViewLanguage()->getCode();
-                               $this->html( 'pageLanguage' );
+                               $this->data['pageLanguage'] = $this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode();
+                               $this->text( 'pageLanguage' );
                        ?>"><span dir="auto"><?php $this->html( 'title' ) ?></span></h1>
                        <div id="bodyContent">
                                <?php if ( $this->data['isarticle'] ) { ?>
index cc2e067..468e74c 100644 (file)
                assert.assertTrue( $content.is( ':hidden' ), 'after collapsing: content is hidden' );
        } );
 
+       QUnit.test( 'mw-made-collapsible data added', 1, function ( assert ) {
+               var $collapsible;
+               $collapsible = prepareCollapsible(
+                       '<div>' + loremIpsum + '</div>'
+               );
+               assert.equal( $collapsible.data( 'mw-made-collapsible' ), true, 'mw-made-collapsible data present' );
+       } );
+
+       QUnit.test( 'mw-collapsible added when missing', 1, function ( assert ) {
+               var $collapsible;
+               $collapsible = prepareCollapsible(
+                       '<div>' + loremIpsum + '</div>'
+               );
+               assert.assertTrue( $collapsible.hasClass( 'mw-collapsible' ), 'mw-collapsible class present' );
+       } );
+
+       QUnit.test( 'mw-collapsed added when missing', 1, function ( assert ) {
+               var $collapsible;
+               $collapsible = prepareCollapsible(
+                       '<div>' + loremIpsum + '</div>',
+                       { collapsed: true }
+               );
+               assert.assertTrue( $collapsible.hasClass( 'mw-collapsed' ), 'mw-collapsed class present' );
+       } );
+
        QUnit.asyncTest( 'initial collapse (mw-collapsed class)', 2, function ( assert ) {
                var $collapsible, $content;
                $collapsible = prepareCollapsible(